0.2 rc2 #4222
0.2 rc2 #4222
Conversation
|
I've assigned @joostjager as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4222 +/- ##
==========================================
- Coverage 88.87% 88.85% -0.03%
==========================================
Files 180 180
Lines 138000 138000
Branches 138000 138000
==========================================
- Hits 122654 122620 -34
- Misses 12529 12561 +32
- Partials 2817 2819 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - name: Install Rust ${{ env.TOOLCHAIN }} toolchain | ||
| run: | | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }} | ||
| - name: Pin the syn and regex dependencies |
There was a problem hiding this comment.
Eh, quote is a part of syn, basically 🤷♂️
| cd fuzz && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106" | ||
| cd write-seeds && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106" | ||
| cd fuzz && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106" && cargo update -p quote --precise "1.0.41" | ||
| cd write-seeds && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106" && cargo update -p quote --precise "1.0.41" |
There was a problem hiding this comment.
I couldn't find any context for this change. It's not a backport, or is it? I am assuming it isn't necessary in main because of the MSRV bump.
There was a problem hiding this comment.
Indeed, main has a higher MSRV.
Given that most users would only be able to test this once we ship LDK Node 0.7-rc.1 I think it makes sense to wait and give them at least ~a week after the RC to report any issues. |
5 participants
If we're waiting on ldk-node anyway, we might as well do an rc2. I guess we could just go ahead and do 0.2-final too, its been a week or two of 0.2-rc1 and only splice-compat issues and some really minor stuff really came up. Thoughts?