Backport 4234 to 0.2 #4239
Backport 4234 to 0.2 #4239
Conversation
Original context and motivation comes from here: lightningdevkit/ldk-node#677 (comment) When splicing-in, the default case is our channel utxo + our wallet utxos being combined. This works great however, it can give our wallet issues calculating fees after the fact because our wallet needs to know about our channel's utxo. We currently have it's outpoint and satoshi value available, but not its output script so we are unable to construct the TxOut for the channel. This adds the redeem script to the `ChannelDetails` and `ChannelPending` event which gives us enough information to be able to construct it.
|
I've assigned @wpaulino as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4239 +/- ##
==========================================
- Coverage 88.87% 88.85% -0.02%
==========================================
Files 180 180
Lines 138000 138039 +39
Branches 138000 138039 +39
==========================================
+ Hits 122642 122659 +17
- Misses 12534 12559 +25
+ Partials 2824 2821 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
@TheBlueMatt up to you if you want to include it this late in the cycle
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
There was a problem hiding this comment.
Seems this needs a rebase.
Also, I want to note that this breaks SemVer rules as adding new fields to enum variants are considered major changes.
4 participants
Backports #4234