-
Notifications
You must be signed in to change notification settings - Fork 41
fix triggerforceclose cmd #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix triggerforceclose cmd #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ⛷
The change looks good.
nit: I propose to add a unit test for this command to make sure it works. We can do it in a separate PR not to block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Testing this command in a unit test isn't easy. That's why I started #207, which does include an integration test for |
Hello, unsure if I should have rerun yet or not, but I pulled the latest
Command run:
Output:
I also tried adding the flags:
…but
It seems the internal defaults still violate the Many Thanks for having a look!!!! |
@Ellienat you need to compile the code from this pull request for the fix to work. |
65e5b9d
to
513f7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 🎉
thanks @guggero that worked now and was able to connect to IP address nodes without any errors, unfortunately though unable to solve stuck channel issue. I'll revert back to original ticket to explore if any other options to resolve. |
@Ellienat I added an additional fix in #207, can you try again with |
See lightningnetwork/lnd#10276 (comment) for more info