Skip to content

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Oct 8, 2025

Copy link
Contributor

@starius starius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The change looks good.

nit: I propose to add a unit test for this command to make sure it works. We can do it in a separate PR not to block.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@guggero
Copy link
Collaborator

guggero commented Oct 8, 2025

nit: I propose to add a unit test for this command to make sure it works. We can do it in a separate PR not to block.

Testing this command in a unit test isn't easy. That's why I started #207, which does include an integration test for triggerforceclose.

@Ellienat
Copy link

Ellienat commented Oct 9, 2025

Hello, unsure if I should have rerun yet or not, but I pulled the latest master build of chantools and ran triggerforceclose on this channel:

Peer: 02fe6a27ddcb2dd9fa8479fe1d52549b5932079a493b51f1409fa2c5878f1bc07c@65.108.134.61:9735 Channel point: da72f710178fefb50ad13f44dbcf50aa00c04209484da62de2195fa26481b1b5:1

Command run:

~/go/bin/chantools triggerforceclose --peer 02fe6a27ddcb2dd9fa8479fe1d52549b5932079a493b51f1409fa2c5878f1bc07c@65.108.134.61:9735 \ --channel_point da72f710178fefb50ad13f44dbcf50aa00c04209484da62de2195fa26481b1b5:1

Output:

2025-10-09 09:07:20.270 [INF] CHDB: Checking for schema update: latest_version=33, db_version=33 Error: error connecting to peer: unable to create channel status manager: chan-enable-timeout + chan-status-sample-interval must <= chan-disable-timeout and all three chan configs must be positive integers

I also tried adding the flags:

--chan-enable-timeout 10 --chan-status-sample-interval 5 --chan-disable-timeout 30

…but chantools responds with:

unknown flag: --chan-enable-timeout

It seems the internal defaults still violate the enable + sample <= disable rule. Can you confirm if master now sets valid internal defaults, or if further adjustments are required?

Many Thanks for having a look!!!!

@guggero
Copy link
Collaborator

guggero commented Oct 9, 2025

@Ellienat you need to compile the code from this pull request for the fix to work.
So after git clone ... you run git checkout 65e5b9d025565cfe86100980427e095369331023 and then compile/install with make install.

@ziggie1984 ziggie1984 force-pushed the fix-forceclose-trigger branch from 65e5b9d to 513f7f2 Compare October 10, 2025 09:44
@ziggie1984 ziggie1984 requested a review from guggero October 10, 2025 09:45
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@Ellienat
Copy link

thanks @guggero that worked now and was able to connect to IP address nodes without any errors, unfortunately though unable to solve stuck channel issue. I'll revert back to original ticket to explore if any other options to resolve.

@guggero guggero merged commit 2b59a56 into lightninglabs:master Oct 10, 2025
2 checks passed
@guggero
Copy link
Collaborator

guggero commented Oct 10, 2025

thanks @guggero that worked now and was able to connect to IP address nodes without any errors, unfortunately though unable to solve stuck channel issue. I'll revert back to original ticket to explore if any other options to resolve.

@Ellienat I added an additional fix in #207, can you try again with git pull && git checkout c94224d8 && make install?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants