Add itest framework and implement first integration tests #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues: 1. Some new peer related config values weren't set, leading to an error. 2. Triggering the force close with a CLN node can be timing-sensitive. It appears that trying both methods independently directly after connecting yields the most reliable result.
|
@ziggie1984: review reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a docker compose based integration test framework that first spins up a couple of nodes, creates channels with some payments then uses that node state for running Golang based integration tests.
Currently we test the three most popular commands:
sweepremoteclosed: Sweep funds from previously remotely force closed channels, supports LND and CLN.triggerforceclose: Attempt to trigger a force close by connecting to the channel peer, supports LND and CLN.zombierecovery: Cooperatively close zombie channels using PSBTs, supports LND and CLN.This PR also fixes an issue with
triggerforcecloseitself that caused the command to not always work for CLN peers.cc @ziggie1984, @starius, @bitromortac