Add Bitcoin Core 23.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkmassive
force-pushed
the
bitcoind-23.0
branch
from
24f46da to
3a47b8b
Compare
|
I think it's good to go for an upstream PR if we drop the last commit. Mainly wanted to get your input about removing that one problematic signature in case you have a better idea for handling it @guggero |
thinkmassive
force-pushed
the
bitcoind-23.0
branch
5 times, most recently
from
e1f15e5 to
5aa77e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our repo diverged from the upstream ruimarinho repo, because that one didn't yet have v22.0 when we wanted to build the images. This PR adds Bitcoin Core 23.0 to the upstream, along with a small change to allow the github workflow to push images to other Docker Hub repos. It has conflicts with our master branch, although I think we may want to replace our old master with one that's more forward-compatible with upstream.
It took quite a while to work out issues with the gpg keys, so I'm opening this here first, as a draft to gather feedback. There will also be a breaking change with one Github secrets names:
DOCKER_API_KEYwas reverted toDOCKER_HUB_PASSWORDto match upstreamDOCKER_USERNAMEwas renamed toDOCKER_HUB_USERfor consistencyThe other major change to the github workflow, compared with our current master, is we changed
docker/login-action@v1tolightninglabs/gh-actions/login-action@2021.01.25.00. It does seem preferable to use one under our control and/or pin an exact version, so this might be a change we need to re-apply on our fork with each release.As far as building the image itself, the Dockerfiles are nearly the same as v22.0. The main difference was updating the gpg keys, and removing one problematic sig from SHA256SUMS.asc (using
sed) for which I could not find a usable public key from any keyservers:It was found on
keys.openpgp.org, however the identity was stripped, so it wasn't easily usable. I'm not sure if this is likely to eventually propagate to other keyservers, and/or the sig removed from SHA256SUMS.asc if it causes problems for many others. Ultimately I think a better solution might be bitcoin/bitcoin/pull/23020, but I think it should only be included after it's merged.