This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Include limbo balance in Home screen balance. #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
suggested changes
Mar 13, 2019
src/action/wallet.js
Outdated
| log.error('Getting limbo balance failed', err); | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
store.limboBalanceSatoshis should be done in getPendingChannels of channel actions as that grpc api is already being polled. Doing it here would result in the api being polled twice.
| pendingBalanceSatoshis + | ||
| channelBalanceSatoshis + | ||
| limboBalanceSatoshis | ||
| ); |
Contributor
There was a problem hiding this comment.
Although store.limboBalanceSatoshis is set in channel actions I would also compute this here 👍
Contributor
Author
There was a problem hiding this comment.
Sorry, I'm confused what this means. What is being computed?
Contributor
There was a problem hiding this comment.
Just saying it makes sense to use the ComputedWallet module here. So no changes needed :)
| expect(store.totalBalanceSatoshis, 'to equal', 100010001); | ||
| expect(store.totalBalanceLabel, 'to match', /1[,.]000[,.]100[,.]01/); | ||
| expect(store.totalBalanceSatoshis, 'to equal', 100010101); | ||
| expect(store.totalBalanceLabel, 'to match', /1[,.]000[,.]101[,.]01/); |
tanx
approved these changes
Mar 14, 2019
| pendingBalanceSatoshis + | ||
| channelBalanceSatoshis + | ||
| limboBalanceSatoshis | ||
| ); |
Contributor
There was a problem hiding this comment.
Just saying it makes sense to use the ComputedWallet module here. So no changes needed :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1006.