Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@tanx
Copy link
Contributor

@tanx tanx commented Mar 19, 2019

No description provided.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis seems OK with this change! Are you still doing macOS testing? I'll approve but with the caveat we should make sure we don't have a massive performance regression first ;D

@tanx
Copy link
Contributor Author

tanx commented Mar 20, 2019

Travis seems OK with this change! Are you still doing macOS testing? I'll approve but with the caveat we should make sure we don't have a massive performance regression first ;D

@valentinewallace yeah. I'd like to figure out whether the lnd regression #1028 I discovered yesterday is caused by go 1.12 or the current lnd master. If it's lnd master then the only thing holding go 1.12 is the performance regression. As @halseth pointed out, it might make sense to prioritize disk integrity/safety over performance. We should still test a sync on testnet and mainnet with go 1.12 either way though to see if it really makes such a big difference to app users. If I understand correctly the performance regression is only be on desktop/macOS and as @Roasbeef pointed out, neutrino starts syncing instantly now anyway when the app is opened.

@tanx tanx merged commit d2043dd into master Apr 2, 2019
@tanx tanx deleted the go-1.12.1 branch April 2, 2019 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants