Dev/blank seed #1207
Dev/blank seed #1207
Conversation
src/action/wallet.js
Outdated
| */ | ||
| initRestoreWallet() { | ||
| this._store.seedMnemonic = Array(24).fill(''); | ||
| this._store.restoreSeedMnemonic = Array(24).fill(''); |
There was a problem hiding this comment.
So the seed words were empty because the user navigated to RestoreWallet after the seed had been set by wallet.generateSeed? Couldn't we just call wallet.generateSeed() in wallet.initSeed()?
There was a problem hiding this comment.
That works, fixed!
Note that we still need this call to generateSeed(), so initSeed's generateSeed() call will be redundant most of the time.
There was a problem hiding this comment.
Thanks for looking into this variant. I just noticed that we use wallet.generateSeed to check if a wallet already exists. Calling it twice without handling the error would create another potential error case. I think you made the right call in the first version of your PR to add store.restoreSeedMnemonic. I reopened that variant in #1247 and am closing this one.
… seed" This reverts commit d611a5a.
valentinewallace
force-pushed
the
dev/blank-seed
branch
from
33bc4a7 to
a6ea615
Compare
Closes #1198.