Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Add fee estimation failure details to error message. #1254

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Add fee estimation failure details to error message. #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/action/payment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,10 @@ class PaymentAction {
}
this._nav.goPayBitcoinConfirm();
} catch (err) {
this._notification.display({ msg: 'Fee estimation failed!', err });
this._notification.display({
msg: `Fee estimation failed: ${err.details}`,
err,
});
Copy link
Contributor

@tanx tanx Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err.details has always been undefined for other errors thrown on mobile. Did this work in your test?

Copy link
Contributor Author

@valentinewallace valentinewallace Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it did, but I can add a null check.

}
}

Expand Down