This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Add fee estimation failure details to error message. #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
reviewed
Jul 18, 2019
| this._notification.display({ | ||
| msg: `Fee estimation failed: ${err.details}`, | ||
| err, | ||
| }); |
Contributor
There was a problem hiding this comment.
err.details has always been undefined for other errors thrown on mobile. Did this work in your test?
Contributor
Author
There was a problem hiding this comment.
Yes it did, but I can add a null check.
tanx
approved these changes
Jul 22, 2019
Contributor
|
Reopening this since @valentinewallace does this work for you? |
ThinkWard-Ltd
added a commit
to ThinkWard-Ltd/lightning-app
that referenced
this pull request
Jan 8, 2021
…err-msg Add fee estimation failure details to error message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assists in solving #1161.