This repository was archived by the owner on Feb 23, 2021. It is now read-only.
ios native: pass localizedDescription as error message #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will also be part of the passed NSError, but this makes the error message explicit.
valentinewallace
approved these changes
Aug 7, 2019
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
LGTM 🥇 Ty @halseth!! I pushed a follow-up commit to display the error rather than err.details, tested and it worked for me.
tanx
suggested changes
Aug 7, 2019
| } catch (err) { | ||
| this._notification.display({ | ||
| msg: `Fee estimation failed: ${err.details}`, | ||
| msg: `Fee estimation failed: ${err}`, |
Contributor
There was a problem hiding this comment.
@halseth can we change it so that err is an object that has the string on a message attribute so that we can access it like a normal JS Error like so: err.message?
Contributor
Author
There was a problem hiding this comment.
I can't really set anything, it is react-native that creates this error object.
Contributor
There was a problem hiding this comment.
To clarify, we're not getting an error object here. err is a string.
Contributor
Author
There was a problem hiding this comment.
Ok, I guess that's what React Native throws then :)
Contributor
|
Closing in favor of #1292 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will also be part of the passed NSError, but this makes the error
message explicit.