This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Implement loader - syncing chain screen #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
suggested changes
Jul 4, 2018
Contributor
tanx
left a comment
tanx
left a comment
There was a problem hiding this comment.
Looks great! I added some minor style adjustments and made a few comments
src/store.js
Outdated
| walletUnlocked: false, // Is the wallet unlocked | ||
| lndReady: false, // Is lnd process running | ||
| syncedToChain: false, // Is lnd synced to blockchain | ||
| percentSynced: 0, // Expects 0-100 range |
Contributor
There was a problem hiding this comment.
I'm wondering if it wouldn't be easier to use a float here between 0 and 1. generateArc divides it by 100 anyway:
lightning-app/src/component/spinner.js
Lines 145 to 151 in 4bf9624
| LoadNetworkSpinner.propTypes = { | ||
| percentage: PropTypes.number.isRequired, | ||
| msg: PropTypes.string.isRequired, | ||
| }; |
Contributor
There was a problem hiding this comment.
Why move the component out of the component library? Seems to me it just makes things more complicated if we decide to reuse the spinner somewhere else.
valentinewallace
force-pushed
the
loader-syncing
branch
from
5cd9d9a to
d9c9791
Compare
tanx
approved these changes
Jul 9, 2018
Contributor
tanx
left a comment
tanx
left a comment
There was a problem hiding this comment.
Awesome! Just made a few minor changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255