Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@tanx
Copy link
Contributor

@tanx tanx commented Jul 18, 2018

Closes #432

@tanx tanx requested a review from valentinewallace July 18, 2018 11:16
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

Not sure what the policy is on me pushing commits to your branches, but I just added a message so that a note is shown in the storybook for pay-lightning-confirm.

Tested the packaged app and it looks great! I'm wondering if there's a character limit that we should be abiding by or not

status: 'complete',
date: new Date(),
}));
store.payment.note = '#craefulgang';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this so that the storybook shows a note

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@tanx
Copy link
Contributor Author

tanx commented Jul 19, 2018

Not sure what the policy is on me pushing commits to your branches, but I just added a message so that a note is shown in the storybook for pay-lightning-confirm.

That's fine. I think giving each other another chance to review the changes is a good idea. I have been a bit too optimistic on my end about that. Will try to give you a chance to review as well.

@tanx
Copy link
Contributor Author

tanx commented Jul 19, 2018

Tested the packaged app and it looks great! I'm wondering if there's a character limit that we should be abiding by or not

It's limited to one line for now and sets ... if the string is longer.

@tanx tanx merged commit 8d178ab into master Jul 19, 2018
@tanx tanx deleted the invoice-note branch July 19, 2018 04:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants