Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Sep 17, 2018

This only changes the styling of the initial NewAddress view. Closes: #682

Before:
before

After:
after

This only changes the styling of the initial `NewAddress` view.

Closes: #682
@philippgille
Copy link

I don't know, now it overlays the "Done" button. It might be personal preference, but this still doesn't look clean to me.

Why not make the toast message smaller by putting the icon in front of the text? It's so big compared to its related button to trigger the copy action. When the toast is smaller, it might just fit perfectly between the address and the Done button.

@ghost
Copy link
Author

ghost commented Sep 18, 2018

Closing as this needs some additional thought.

@ghost ghost closed this Sep 18, 2018
@valentinewallace
Copy link
Contributor

valentinewallace commented Sep 28, 2018

@ERKarl I talked to our designer and we think this solution is fine for now :) Reopening. Btw, our CLA is set up now!

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like this solution for now :)

},
copied: {
bottom: 180,
bottom: 60,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V simple.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting color={color.notifyDark} on CopiedNotification in line 60 is probably cleaner: https://github.com/lightninglabs/lightning-app/pull/688/files#diff-7ed4897f600feac8ff2579bda31e993aR60

@ghost
Copy link
Author

ghost commented Oct 1, 2018

@valentinewallace CLA updated.

},
copied: {
bottom: 180,
bottom: 60,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting color={color.notifyDark} on CopiedNotification in line 60 is probably cleaner: https://github.com/lightninglabs/lightning-app/pull/688/files#diff-7ed4897f600feac8ff2579bda31e993aR60

@tanx
Copy link
Contributor

tanx commented Oct 2, 2018

Closing in favor of #707

@tanx tanx closed this Oct 2, 2018
@ghost ghost deleted the clipboard-copy-cosmetics branch October 2, 2018 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants