-
Notifications
You must be signed in to change notification settings - Fork 168
Adjust copied to clipboard position in NewAddress #688
Conversation
This only changes the styling of the initial `NewAddress` view. Closes: #682
|
I don't know, now it overlays the "Done" button. It might be personal preference, but this still doesn't look clean to me. Why not make the toast message smaller by putting the icon in front of the text? It's so big compared to its related button to trigger the copy action. When the toast is smaller, it might just fit perfectly between the address and the Done button. |
|
Closing as this needs some additional thought. |
|
@ERKarl I talked to our designer and we think this solution is fine for now :) Reopening. Btw, our CLA is set up now! |
valentinewallace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like this solution for now :)
| }, | ||
| copied: { | ||
| bottom: 180, | ||
| bottom: 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting color={color.notifyDark} on CopiedNotification in line 60 is probably cleaner: https://github.com/lightninglabs/lightning-app/pull/688/files#diff-7ed4897f600feac8ff2579bda31e993aR60
|
@valentinewallace CLA updated. |
| }, | ||
| copied: { | ||
| bottom: 180, | ||
| bottom: 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting color={color.notifyDark} on CopiedNotification in line 60 is probably cleaner: https://github.com/lightninglabs/lightning-app/pull/688/files#diff-7ed4897f600feac8ff2579bda31e993aR60
|
Closing in favor of #707 |
This only changes the styling of the initial
NewAddressview. Closes: #682Before:

After:
