This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Password mobile #771
Merged
Password mobile #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the same horizontal transition layer.
valentinewallace
approved these changes
Nov 2, 2018
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Sehr gut :D The components built in the set password PR integrated nicely!
|
|
||
| const MainStack = createStackNavigator( | ||
| { | ||
| Password, |
Contributor
There was a problem hiding this comment.
Did you test these new views by commenting out the set password parts of the stack? I couldn't figure out any other way.
Contributor
Author
There was a problem hiding this comment.
You can also tests the screen in the browser using regular storybook. But yes, I commented out the other screens to test the password view on mobile.
| }, | ||
| }); | ||
|
|
||
| const PasswordView = ({ store, wallet }) => ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #586