This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Fix integration test flakes. #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is useful when a process is being killed and then restarted, because if a process has not been fully killed when its restart is attempted it will silently fail to restart. This function ensures a process has been terminated before returning because will error if given a pid for a process that doesn't exist.
Previously, we were attempting to restart btcd before the original process was fully terminated, causing the restart to silently fail.
valentinewallace
force-pushed
the
fix-integ-test-flakes
branch
from
8c92119 to
36e9b93
Compare
tanx
reviewed
Nov 5, 2018
| await nap(500); | ||
| } catch (e) { | ||
| terminated = true; | ||
| } |
There was a problem hiding this comment.
What if process.kill() is successful? Will it still throw an exception?
There was a problem hiding this comment.
If process.kill() is successful, then it will error on the next attempt to kill it because the process doesn't exist anymore. I couldn't find any other way to determine whether the process was actually dead.
Tried process.terminated, tried process.on(SIGINT)/other event handlers. Those could probably work if I put in a sleep after they occur and then restarted btcd, but I wanted to avoid sleeps.
There was a problem hiding this comment.
Ah ok. Let's see if this helps.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #761.
There is one odd flake that has a slightly different failure, but the other 17 or so had the same failure.
I've been experiencing this flake locally for a while now, and I'm not sure what about
reset-passwordcaused it to suddenly surface in production. Regardless, this change fixed it for me locally so I think it should fix it on travis as well.