-
Notifications
You must be signed in to change notification settings - Fork 108
dev.Dockerfile: allow forcing lnd/tapd/taprpc/loop repo #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev.Dockerfile: allow forcing lnd/tapd/taprpc/loop repo #1118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the dev.Dockerfile to provide greater flexibility in building the lightning-terminal project. It introduces new build arguments that allow developers to specify custom Git repositories for core dependencies like LND, Taproot Assets, TapRPC, and Loop, ensuring that specific versions can be pulled even if they don't exist in the default upstream repositories.
Highlights
- Custom Repository Support: Added
LND_REPO,TAPROOT_ASSETS_REPO,TAPRPC_REPO, andLOOP_REPObuild arguments todev.Dockerfile. These arguments enable specifying alternative Git repositories for the respective Go modules, allowing commits to be referenced even if they don't exist in the default upstream. - Conditional Module Replacement: Modified the Dockerfile's build steps to use
go mod edit -replacewhen a custom repository is provided for a module (LND, Taproot Assets, TapRPC, Loop). This ensures that the build process can fetch specific versions from non-default sources, falling back togo getif no custom repo is specified. - Loop Module Versioning: Extended the existing version forcing mechanism to include the
loopmodule, allowing its version to be specified viaLOOP_VERSIONand its repository viaLOOP_REPO.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the dev.Dockerfile by enabling the specification of custom repositories for lnd, taproot-assets, taprpc, and loop dependencies. To improve maintainability, the comments should be updated to reflect the addition of loop. Additionally, consolidating the go mod tidy calls into a single execution at the end of the dependency updates would optimize the build process.
We can now use the LND_REPO, TAPROOT_ASSETS_REPO, TAPRPC_REPO, and LOOP_RPC build arguments to force a specific repo to be used so that commits referenced by LND_VERSION, TAPROOT_ASSETS_VERSION, TAPRPC_VERSION, and LOOP_VERSION don't have to exist in the default repository. If any of these build arguments are not defined, the build continues using the default repository for that module. NOTE: If these arguments ARE defined then the corresponding `_VERSION` argument MUST also be defined, otherwise the build continues using the default repository defined for that module.
de4d7b2 to
6091fd8
Compare
3875ec4 to
f4b0790
Compare
|
I've fixed the compilation issue in the |
|
Deleted the branch as it had a confusing name. Needs to be re-opened against the |
We can now use the LND_REPO, TAPROOT_ASSETS_REPO, TAPRPC_REPO, and
LOOP_RPC build arguments to force a specific repo to be used so that
commits referenced by LND_VERSION, TAPROOT_ASSETS_VERSION,
TAPRPC_VERSION, and LOOP_VERSION don't have to exist in the default
repository. If any of these build arguments are not defined, the build
continues using the default repository for that module.
NOTE: If these arguments ARE defined then the corresponding
_VERSIONargument MUST also be defined, otherwise the build continuesusing the default repository defined for that module.