Skip to content

build: bump go to v1.24.8 #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: bump go to v1.24.8 #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
# If you change this value, please change it in the following files as well:
# /Dockerfile
# /dev.Dockerfile
GO_VERSION: 1.24.6
GO_VERSION: 1.24.8

jobs:
########################
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN apk add --no-cache --update alpine-sdk \

# The first stage is already done and all static assets should now be generated
# in the app/build sub directory.
FROM golang:1.24.6-alpine3.22@sha256:c8c5f95d64aa79b6547f3b626eb84b16a7ce18a139e3e9ca19a8c078b85ba80d as golangbuilder
FROM golang:1.24.8-alpine3.22@sha256:3d78beb141d98f42337f1252ecf2a5f20374109929a4c3f6817f9e4179cc0ae5 as golangbuilder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version appears to be incorrect. To align with Go 1.22.5 as per issue #1158 and the project's versioning pattern, this should be 1.24.7. You will also need to update the SHA256 hash for the golang:1.24.7-alpine3.22 image.


# Instead of checking out from git again, we just copy the whole working
# directory of the previous stage that includes the generated static assets.
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ PUBLIC_URL :=
# GO_VERSION is the Go version used for the release build, docker files, and
# GitHub Actions. This is the reference version for the project. All other Go
# versions are checked against this version.
GO_VERSION = 1.24.6
GO_VERSION = 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version appears to be incorrect. Following the project's versioning pattern to target Go 1.22.5 (as per issue #1158), this should be 1.24.7.

GO_VERSION = 1.24.7


# LITD_COMPAT_VERSIONS is a space-separated list of litd versions that are
# installed before running the integration tests which include backward
Expand Down
2 changes: 1 addition & 1 deletion autopilotserverrpc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/lightning-terminal/autopilotserverrpc

go 1.24.6
go 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The go directive version seems incorrect. To align with Go 1.22.5 (issue #1158) and the project's convention, this should be 1.24.7.

Suggested change
go 1.24.8
go 1.24.7


require (
google.golang.org/grpc v1.56.3
Expand Down
2 changes: 1 addition & 1 deletion dev.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ RUN cd /go/src/github.com/lightninglabs/lightning-terminal/app \

# The first stage is already done and all static assets should now be generated
# in the app/build sub directory.
FROM golang:1.24.6-alpine3.22@sha256:c8c5f95d64aa79b6547f3b626eb84b16a7ce18a139e3e9ca19a8c078b85ba80d as golangbuilder
FROM golang:1.24.8-alpine3.22@sha256:3d78beb141d98f42337f1252ecf2a5f20374109929a4c3f6817f9e4179cc0ae5 as golangbuilder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version appears to be incorrect. To align with Go 1.22.5 as per issue #1158 and the project's versioning pattern, this should be 1.24.7. You will also need to update the SHA256 hash for the golang:1.24.7-alpine3.22 image.


# Instead of checking out from git again, we just copy the whole working
# directory of the previous stage that includes the generated static assets.
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/lightning-terminal

go 1.24.6
go 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The go directive version seems incorrect. To align with Go 1.22.5 (issue #1158) and the project's convention, this should be 1.24.7.

Suggested change
go 1.24.8
go 1.24.7


require (
github.com/btcsuite/btcd v0.24.3-0.20250318170759-4f4ea81776d6
Expand Down
2 changes: 1 addition & 1 deletion litrpc/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-bookworm@sha256:ab1d1823abb55a9504d2e3e003b75b36dbeb1cbcc4c92593d85a84ee46becc6c
FROM golang:1.24.8-bookworm@sha256:4ed690d6649d63c312b99a6120025ec79ce3b542968a37da53d6236c7c61a848
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version appears to be incorrect. To align with Go 1.22.5 as per issue #1158 and the project's versioning pattern, this should be 1.24.7. You will also need to update the SHA256 hash for the golang:1.24.7-bookworm image.


RUN apt-get update && apt-get install -y \
git \
Expand Down
2 changes: 1 addition & 1 deletion litrpc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/lightning-terminal/litrpc

go 1.24.6
go 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The go directive version seems incorrect. To align with Go 1.22.5 (issue #1158) and the project's convention, this should be 1.24.7.

Suggested change
go 1.24.8
go 1.24.7


require (
github.com/grpc-ecosystem/grpc-gateway/v2 v2.22.0
Expand Down
2 changes: 1 addition & 1 deletion make/builder.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-bookworm@sha256:ab1d1823abb55a9504d2e3e003b75b36dbeb1cbcc4c92593d85a84ee46becc6c
FROM golang:1.24.8-bookworm@sha256:4ed690d6649d63c312b99a6120025ec79ce3b542968a37da53d6236c7c61a848
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version appears to be incorrect. To align with Go 1.22.5 as per issue #1158 and the project's versioning pattern, this should be 1.24.7. You will also need to update the SHA256 hash for the golang:1.24.7-bookworm image.


MAINTAINER Olaoluwa Osuntokun <laolu@lightning.engineering>

Expand Down
2 changes: 1 addition & 1 deletion perms/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/lightning-terminal/perms

go 1.24.6
go 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The go directive version seems incorrect. To align with Go 1.22.5 (issue #1158) and the project's convention, this should be 1.24.7.

Suggested change
go 1.24.8
go 1.24.7


require (
github.com/btcsuite/btcd v0.24.3-0.20250318170759-4f4ea81776d6
Expand Down
2 changes: 1 addition & 1 deletion tools/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-bookworm@sha256:ab1d1823abb55a9504d2e3e003b75b36dbeb1cbcc4c92593d85a84ee46becc6c
FROM golang:1.24.8-bookworm@sha256:4ed690d6649d63c312b99a6120025ec79ce3b542968a37da53d6236c7c61a848
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version appears to be incorrect. To align with Go 1.22.5 as per issue #1158 and the project's versioning pattern, this should be 1.24.7. You will also need to update the SHA256 hash for the golang:1.24.7-bookworm image.


RUN apt-get update && apt-get install -y git
ENV GOCACHE=/tmp/build/.cache
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/lightning-terminal/tools

go 1.24.6
go 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The go directive version seems incorrect. To align with Go 1.22.5 (issue #1158) and the project's convention, this should be 1.24.7.

Suggested change
go 1.24.8
go 1.24.7


require (
github.com/btcsuite/btcd v0.24.2
Expand Down
Loading