Skip to content

Conversation

@jbrill
Copy link
Contributor

@jbrill jbrill commented Dec 15, 2025

Summary

  • Update daemon proto versions:

    • lnd: v0.19.1-beta → v0.20.0-beta
    • tapd: v0.6.0 → v0.7.0
    • lit: v0.15.0-alpha → v0.16.0-alpha
    • pool: v0.6.6-beta → v0.6.4-beta
    • faraday: v0.2.16-alpha → v0.2.14-alpha
  • Add missing proto files:

    • lnd: peersrpc/peers.proto, stateservice.proto
    • tapd: tapcommon.proto, authmailboxrpc/mailbox.proto
  • Bump version to v0.3.5-alpha

Test plan

  • Run yarn update-protos && yarn generate to verify proto generation succeeds
  • Run yarn build to verify TypeScript compilation
  • Test with lnc-web via yarn link to verify compatibility with new LNC WASM version

Copy link
Collaborator

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🔥, thanks 🙏!

We usually include an extra commit that bumps the version of lnc-core though, and then before merging it, we test that it works properly with lnc-web with yarn link.

Should we do the normal approach, or merge this as is first?

"name": "@lightninglabs/lnc-core",
"version": "0.3.4-alpha",
"description": "Type definitions and utilities for Lightning Node Connect",
"main": "./dist/index.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually include a commit that bumps the version above as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped!

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you taking a stab at this. It's better if we all are familiar with the process to update these packages.

I just happened to notice that there was a new proto added to tapd in the latest release that needs to be added to our scripts:
https://github.com/lightninglabs/taproot-assets/blob/main/taprpc/authmailboxrpc/mailbox.proto

I then checked the other daemons and found a couple in lnd that we never added in the past. Would you mind updating the scripts to include these?
https://github.com/lightningnetwork/lnd/blob/master/lnrpc/peersrpc/peers.proto
https://github.com/lightningnetwork/lnd/blob/master/lnrpc/stateservice.proto


I ran yarn update-protos && yarn generate which produced an error.

tapcommon.proto: File not found.
taprootassets.proto:3:1: Import "tapcommon.proto" was not found or had errors.
taprootassets.proto:246:5: "OutPoint" is not defined.
taprootassets.proto:1452:5: "OutPoint" is not defined.
taprootassets.proto:1934:14: "taprpc.OutPoint" is not defined.
taprootassets.proto:1953:5: "taprpc.OutPoint" is not defined.

It looks like tapcommon.proto was never added to our scripts. Can you add this as well.


As @ViktorT-11 mentioned, it would be helpful to pair this with an lnc-web PR so that we can easily test this with the new LNC WASM version.

@jbrill
Copy link
Contributor Author

jbrill commented Dec 16, 2025

@ViktorT-11 @jamaljsr I've created an lnc-web PR here:
lightninglabs/lnc-web#139

Note that CI is failing, as the tag/release has not been created yet. Typically do we create the PR after the tag is cut? I was able to run a yarn link && yarn build step within lnc-web without issues.

Thanks for pointing out the missing protos @jamaljsr! I've updated this PR to include those. Might it make sense to add a yarn update-protos && yarn generate in CI to catch this in the future?

@jbrill jbrill requested a review from jamaljsr December 16, 2025 16:16
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that CI is failing, as the tag/release has not been created yet. Typically do we create the PR after the tag is cut? I was able to run a yarn link && yarn build step within lnc-web without issues.

I left a comment on that PR. Still one more update to make to the code there.
lightninglabs/lnc-web#139 (comment)

Thanks for pointing out the missing protos @jamaljsr! I've updated this PR to include those. Might it make sense to add a yarn update-protos && yarn generate in CI to catch this in the future?

Yup, that's a great idea to avoid missing this in the future.

@jbrill jbrill requested a review from jamaljsr December 16, 2025 23:58
@jbrill
Copy link
Contributor Author

jbrill commented Dec 16, 2025

@jamaljsr think we are ready for another round -- see lightninglabs/lnc-web#139 (comment)

I will update the dependencies / lockfile on lnc-web once this release is cut!

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Works with linked lnc-web and Terminal.

@jbrill jbrill merged commit f74d7e1 into main Dec 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants