Skip to content

Conversation

@sputn1ck
Copy link
Member

This reverts commit b11c959, reversing changes made to 0a182ee.

…deps"

This reverts commit b11c959, reversing
changes made to 0a182ee.
@sputn1ck sputn1ck requested review from hieblmi and starius October 31, 2025 17:49
@gemini-code-assist
Copy link

Summary of Changes

Hello @sputn1ck, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request effectively reverses a previous change that had downgraded project dependencies. It primarily focuses on upgrading the project's Go version to 1.24.6 and updating several critical dependencies like lnd, lndclient, and taproot-assets to their newer releases. Additionally, it significantly enhances the project's documentation capabilities by integrating new tools for generating CLI documentation in standard formats, improving both developer and user experience. The changes also include necessary adaptations to recent updates within the lnd payment database and ensure compatibility with evolving asset HTLC standards.

Highlights

  • Go Version Upgrade: The project's primary Go version has been upgraded to 1.24.6 across various configurations, including the .golangci.yml linter, Dockerfile base image, go.mod file, and release scripts.
  • Core Dependency Updates: Key dependencies such as lndclient, taproot-assets, and lnd have been updated to their latest versions, reflecting recent advancements in the Lightning Network ecosystem.
  • CLI Documentation Generation: New functionality has been introduced to generate comprehensive CLI documentation in both man page and markdown formats, including new man and markdown commands and a custom template for tabular output.
  • LND Payment Database Adaptation: The loopout.go file has been updated to align with changes in lnd's payment database structure and to ensure forward compatibility for asset HTLCs with tapd.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/main.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous commit that downgraded dependencies, effectively upgrading them and adding new documentation generation capabilities. The changes look mostly good, with dependency versions updated across several files (go.mod, Dockerfile, release.sh) and code adapted to the new dependency APIs in loopout.go. The new docs and docs-check Makefile targets are a welcome addition for keeping documentation up-to-date.

However, I've found a few issues:

  • A minor copy-paste error in an error message in cmd/loop/docs.go.
  • A potentially confusing version number in an example in docs/release.md.
  • The Go versions in looprpc/go.mod and swapserverrpc/go.mod are downgraded, which is inconsistent with the upgrade in the root go.mod. This should be corrected to avoid potential build issues and confusion.

@sputn1ck sputn1ck merged commit 3772a40 into lightninglabs:master Nov 3, 2025
6 of 7 checks passed
@sputn1ck sputn1ck deleted the revert_downgrade branch November 3, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants