ci: use current LiT itest target#1099
Merged
starius merged 1 commit intolightninglabs:masterfrom Mar 18, 2026
Merged
Conversation
CI failed: https://github.com/lightninglabs/loop/actions/runs/23082982774/job/67447021668?pr=1090 The workflow called `make itest-no-backward-compat`, but lightning-terminal removed that target in lightninglabs/lightning-terminal@4cedb44 ("itest: remove custom channels tests and backward compat infrastructure").
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
ellemouton
approved these changes
Mar 18, 2026
darioAnongba
approved these changes
Mar 18, 2026
darioAnongba
left a comment
darioAnongba
left a comment
There was a problem hiding this comment.
Approved, even though testing this way is an anti-pattern as it's an inversion of responsibilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed: https://github.com/lightninglabs/loop/actions/runs/23082982774/job/67447021668?pr=1090
The workflow called
make itest-no-backward-compat, but lightning-terminal removed that target inlightninglabs/lightning-terminal@4cedb44 ("itest: remove custom channels tests and backward compat infrastructure").
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes