Skip to content

staticaddr/withdraw: add retry and reorg handling for withdrawals #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaldun-tech wants to merge 2 commits into
base: master
Choose a base branch
from
+248 −100
Open

staticaddr/withdraw: add retry and reorg handling for withdrawals #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4e3a2
staticaddr/withdraw: add retry and reorg handling for withdrawals
kaldun-tech Apr 24, 2026
48a639c
fixup: if else style update to put happy path first in WithdrawDeposits
kaldun-tech Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,13 @@ This file tracks release notes for the loop client.

#### Bug Fixes

* [Static Address Withdrawals: Add retry and reorg handling for withdrawal
confirmations](https://github.com/lightninglabs/loop/issues/1087).
Previously, if `RegisterSpendNtfn` or `RegisterConfirmationsNtfn` failed,
the withdrawal monitoring would silently stop. Additionally, reorgs were not
handled, and state was not persisted before monitoring setup, causing
recovery failures on restart. This fix adds automatic retry on next block
for registration failures, proper reorg detection via `WithReOrgChan`, and
reorders state persistence to occur before monitoring setup.

#### Maintenance
Loading