Skip to content

looprpc: fix build and permissions of two RPCs#1138

Merged
starius merged 2 commits into
lightninglabs:masterfrom
starius:fix-perms
May 9, 2026
Merged

looprpc: fix build and permissions of two RPCs#1138
starius merged 2 commits into
lightninglabs:masterfrom
starius:fix-perms

Conversation

@starius
Copy link
Copy Markdown
Collaborator

@starius starius commented May 7, 2026

Two fixes for looprpc module:

  • looprpc depends on our protobuf-go fork. It failed with compilation errors when building the module itself.

  • Both SweepHtlc and StaticAddressLoopIn are active, so the "swap" entity must have action=execute, not read.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

starius added 2 commits May 7, 2026 02:24
Both SweepHtlc and StaticAddressLoopIn are active, so the "swap" entity
must have action=execute, not read.
It depends on our protobuf-go fork. It failed with compilation errors when
building the module itself.
@starius starius requested review from bhandras and hieblmi May 7, 2026 07:39
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses build failures in the looprpc module by integrating a specific protobuf-go fork and updates security permissions for critical RPC endpoints to ensure proper execution access.

Highlights

  • Dependency Management: Updated the looprpc module to use a custom protobuf-go fork that supports hex formatting for raw bytes, resolving build-time compilation errors.
  • Permission Updates: Corrected the permission levels for SweepHtlc and StaticAddressLoopIn RPCs by changing the 'swap' entity action from 'read' to 'execute'.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the standard google.golang.org/protobuf dependency with a forked version that supports formatting raw bytes as hex instead of base64. Additionally, it updates the required permissions for the SweepHtlc and StaticAddressLoopIn RPC methods, changing the swap entity action from read to execute. I have no feedback to provide.

@starius starius marked this pull request as ready for review May 7, 2026 07:50
Copy link
Copy Markdown
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remeber there being backward compat restrictions with these permissions. Are old clients able to change these perms seamlessly?

@starius
Copy link
Copy Markdown
Collaborator Author

starius commented May 8, 2026

@hieblmi I validated it in regtest. The macaroon created before this fix, works in the updated Loop. I tested both sweephtlc and static loop-in.

@starius starius requested a review from hieblmi May 8, 2026 18:18
Copy link
Copy Markdown
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starius starius merged commit 7c3eb29 into lightninglabs:master May 9, 2026
9 checks passed
@starius starius deleted the fix-perms branch May 9, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants