looprpc: fix build and permissions of two RPCs#1138
Conversation
Both SweepHtlc and StaticAddressLoopIn are active, so the "swap" entity must have action=execute, not read.
It depends on our protobuf-go fork. It failed with compilation errors when building the module itself.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses build failures in the Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request replaces the standard google.golang.org/protobuf dependency with a forked version that supports formatting raw bytes as hex instead of base64. Additionally, it updates the required permissions for the SweepHtlc and StaticAddressLoopIn RPC methods, changing the swap entity action from read to execute. I have no feedback to provide.
hieblmi
left a comment
There was a problem hiding this comment.
I remeber there being backward compat restrictions with these permissions. Are old clients able to change these perms seamlessly?
|
@hieblmi I validated it in regtest. The macaroon created before this fix, works in the updated Loop. I tested both sweephtlc and static loop-in. |
Two fixes for
looprpcmodule:looprpcdepends on our protobuf-go fork. It failed with compilation errors when building the module itself.Both SweepHtlc and StaticAddressLoopIn are active, so the "swap" entity must have action=execute, not read.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes