Skip to content

go.mod: fix gonum replaces (fix CI)#1140

Merged
starius merged 1 commit into
lightninglabs:masterfrom
starius:fix-go-mod-check
May 11, 2026
Merged

go.mod: fix gonum replaces (fix CI)#1140
starius merged 1 commit into
lightninglabs:masterfrom
starius:fix-go-mod-check

Conversation

@starius
Copy link
Copy Markdown
Collaborator

@starius starius commented May 10, 2026

Remove gonum/plot replace in looprpc - not needed.

Add gonum replace to swapserverrpc. It was missing and caused recent CI errors.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the gonum dependency version across the repository and fixes build issues in CI by ensuring all relevant modules have the correct replace directives. It simplifies dependency management by removing redundant configuration in specific sub-packages.

Highlights

  • Dependency Update: Bumped the gonum dependency from v0.11.0 to v0.16.0 in go.mod files to ensure consistent resolution.
  • Cleanup: Removed the unnecessary gonum/plot replace directive in looprpc.
  • Configuration Fix: Added a missing gonum replace directive to swapserverrpc to resolve CI build errors.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gonum dependency from version v0.11.0 to v0.16.0 across the project, including the looprpc and swapserverrpc modules. It also cleans up vanity domain replace directives for gonum.org/v1/plot and updates the corresponding go.sum files to reflect these changes. I have no feedback to provide as there were no review comments to assess.

Remove gonum/plot replace in looprpc - not needed.

Add gonum replace to swapserverrpc. It was missing and caused recent CI errors.
@starius starius force-pushed the fix-go-mod-check branch from 2438805 to 38481fe Compare May 11, 2026 03:04
@starius starius marked this pull request as ready for review May 11, 2026 03:17
@starius starius changed the title go.mod: fix gonum replaces go.mod: fix gonum replaces (fix CI) May 11, 2026
@starius starius requested review from bhandras and hieblmi May 11, 2026 03:17
Copy link
Copy Markdown
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Copy Markdown
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Comment thread swapserverrpc/go.mod

// Avoid fetching gonum vanity domains. The domain is unstable and causes
// "go mod check" failures in CI.
replace gonum.org/v1/gonum => github.com/gonum/gonum v0.11.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the latest release?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the latest release of gonum.org/v1/gonum affects overall version resolution in such a way that it attempts to use github.com/lyft/protoc-gen-validate package which was removed. I decided not to go deeper into dependencies resolution and do a minimum fix to make CI green again.

@starius starius merged commit 0102120 into lightninglabs:master May 11, 2026
10 checks passed
@starius starius deleted the fix-go-mod-check branch May 11, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants