go.mod: fix gonum replaces (fix CI)#1140
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the gonum dependency from version v0.11.0 to v0.16.0 across the project, including the looprpc and swapserverrpc modules. It also cleans up vanity domain replace directives for gonum.org/v1/plot and updates the corresponding go.sum files to reflect these changes. I have no feedback to provide as there were no review comments to assess.
Remove gonum/plot replace in looprpc - not needed. Add gonum replace to swapserverrpc. It was missing and caused recent CI errors.
hieblmi
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
|
|
||
| // Avoid fetching gonum vanity domains. The domain is unstable and causes | ||
| // "go mod check" failures in CI. | ||
| replace gonum.org/v1/gonum => github.com/gonum/gonum v0.11.0 |
There was a problem hiding this comment.
Why not use the latest release?
There was a problem hiding this comment.
Using the latest release of gonum.org/v1/gonum affects overall version resolution in such a way that it attempts to use github.com/lyft/protoc-gen-validate package which was removed. I decided not to go deeper into dependencies resolution and do a minimum fix to make CI green again.
Remove gonum/plot replace in looprpc - not needed.
Add gonum replace to swapserverrpc. It was missing and caused recent CI errors.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes