Skip to content

Conversation

@carlaKC
Copy link
Contributor

@carlaKC carlaKC commented May 4, 2020

Overwrite travis's default of only cloning the last 50 commands so that travis can find the reference point for our linter.

Alternate is to shift reference point: #191

Overwrite travis's default of only cloning the last 50 commands so
that travis can find the reference point for our linter.

As in lightningnetwork/lnd/pull/4026
@carlaKC carlaKC requested review from bhandras and guggero May 4, 2020 12:03
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡ I prefer this solution over moving the reference commit (as this will come and bite us again, down the road).

Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran for 1 min 42 sec

Sounds fast enough

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlaKC carlaKC merged commit b070a4f into lightninglabs:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants