lndclient: extend LightningClient with ListChannels and RouterClient with keysend #203
Conversation
bhandras
force-pushed
the
lndclient_extension
branch
from
5b9b6be to
e8ff2d0
Compare
bhandras
changed the title
lndclient/lightning_client.go
Outdated
|
|
||
| // ListChannels retrieves all channels of the backing lnd node. | ||
| func (s *lightningClient) ListChannels(ctx context.Context) ( | ||
| []*lnrpc.Channel, error) { |
There was a problem hiding this comment.
The idea of the wrapper is to not expose things like string based pubkeys. Ideally we'd create a strongly-typed struct to return a slice of. Can for now just contains the fields that we need.
lndclient/router_client.go
Outdated
| // to complete the full amount. | ||
| MaxParts uint32 | ||
|
|
||
| // KeySend is set to true if the payment request will encode the preimage. |
There was a problem hiding this comment.
payment request generally refers to the hex-encoded invoice. You probably mean the tlv payload?
lndclient/router_client.go
Outdated
| // Override the payment hash. | ||
| rpcReq.DestCustomRecords = make(map[uint64][]byte) | ||
| rpcReq.DestCustomRecords[record.KeySendType] = preimage[:] | ||
| request.PaymentHash = preimage.Hash() |
There was a problem hiding this comment.
Assert that PaymentHash wasn't set, to catch unintended use?
bhandras
force-pushed
the
lndclient_extension
branch
from
e8ff2d0 to
f9a8c72
Compare
|
|
||
| result := make([]ChannelInfo, len(response.Channels)) | ||
| for i, channel := range response.Channels { | ||
| remoteVertex, err := route.NewVertexFromStr(channel.RemotePubkey) |
There was a problem hiding this comment.
Future devs will thank you for the luxury of not having to parse everywhere :)
lndclient/lightning_client.go
Outdated
| PubKeyBytes route.Vertex | ||
|
|
||
| // Capacity is the total amount of funds held in this channel. | ||
| Capacity int64 |
There was a problem hiding this comment.
Can be type btcutil.Amount, just as the balances below
There was a problem hiding this comment.
indeed, that is much better
lndclient/router_client.go
Outdated
| rpcReq.LastHopPubkey = request.LastHopPubkey[:] | ||
| } | ||
| if request.KeySend { | ||
| if !bytes.Equal(request.PaymentHash[:], emptyHash[:]) { |
There was a problem hiding this comment.
If payment hash is optional, it would be better to make it type *lntypes.Hash to avoid the magic value.
There was a problem hiding this comment.
agree, much nicer to have the *lntypes.Hash, done
bhandras
force-pushed
the
lndclient_extension
branch
2 times, most recently
from
de0c509 to
78c358c
Compare
bhandras
force-pushed
the
lndclient_extension
branch
from
78c358c to
1515c92
Compare
lndclient/router_client.go
Outdated
|
|
||
| // Override the payment hash. | ||
| rpcReq.DestCustomRecords = make(map[uint64][]byte) | ||
| rpcReq.DestCustomRecords[record.KeySendType] = preimage[:] |
There was a problem hiding this comment.
Alternative. Fewer characters but more lines :) Non-blocking ofc
rpcReq.DestCustomRecords = map[uint64][]byte {
record.KeySendType: preimage[:],
}
There was a problem hiding this comment.
done, probably compiles to the same code, but more readable :)
bhandras
force-pushed
the
lndclient_extension
branch
from
1515c92 to
fee150c
Compare
| ListTransactions(ctx context.Context) ([]*wire.MsgTx, error) | ||
|
|
||
| // ListChannels retrieves all channels of the backing lnd node. | ||
| ListChannels(ctx context.Context) ([]ChannelInfo, error) |
bhandras
force-pushed
the
lndclient_extension
branch
from
fee150c to
620365b
Compare
bhandras
force-pushed
the
lndclient_extension
branch
from
620365b to
cf9c374
Compare
3 participants
This PR adds
ListChannelstoLightningClientand extendsRouterClient.SendPaymentwith keysend.