lndclient: add lookup invoice #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
May 20, 2020
lndclient/lightning_client.go
Outdated
| AddInvoice(ctx context.Context, in *invoicesrpc.AddInvoiceData) ( | ||
| lntypes.Hash, string, error) | ||
|
|
||
| // LookupInvoice looks up an invoice. |
Contributor
There was a problem hiding this comment.
nit: ...looks up an invoice by its hash. ?
lndclient/lightning_client.go
Outdated
| type Invoice struct { | ||
| // Preimage is the invoice's preimage, which is set if the invoice | ||
| // is settled. | ||
| Preiamge *lntypes.Preimage |
carlaKC
force-pushed
the
lndclient-lookupinvoice
branch
2 times, most recently
from
ee88eb4 to
dc489d3
Compare
bhandras
approved these changes
May 20, 2020
test/lightning_client_mock.go
Outdated
| Hash: hash, | ||
| PaymentRequest: payReqString, | ||
| Amount: in.Value, | ||
| CreationDate: time.Now(), |
Member
There was a problem hiding this comment.
nit: you could just fill creationDate here as it already is set to time.Now() earlier (also it's probably better to use that).
Track the invoices we create with AddInvoice so that we can realistically lookup and settle with the mock.
carlaKC
force-pushed
the
lndclient-lookupinvoice
branch
from
dc489d3 to
a57e34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.