[1/3] loopd: add TLS #286
Merged
[1/3] loopd: add TLS #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparation to be able to listen on a TLS enabled listener, we add a TLS config parameter to the listener setup functions.
As we only use the readMacaroon function inside getClientConn where we have an error return value anyway, we might as well pass the error along correctly instead of failing hard directly.
joostjager
approved these changes
Sep 3, 2020
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
Do you want to add part of the readme of #281 in here?
Users running on testnet will need to add --network=testnet to their loop commands. Also something to mention in the release notes.
Contributor
Author
|
Added the TLS part to the README. |
joostjager
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off the TLS part from #281 to get this merged before the
lnddependencies.