Skip to content

dockerfile: use make rather than go install #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlaKC merged 1 commit into from
Mar 5, 2021
Merged

dockerfile: use make rather than go install #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ ENV GO111MODULE on
RUN apk add --no-cache --update alpine-sdk \
git \
make \
&& cd /go/src/github.com/lightningnetwork/loop/cmd \
&& go install ./...
&& cd /go/src/github.com/lightningnetwork/loop \
&& make install

# Start a new, final image to reduce size.
FROM alpine as final
Expand Down
2 changes: 2 additions & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ This file tracks release notes for the loop client.
#### Breaking Changes

#### Bug Fixes
* The loop dockerfile has been updated to use the `make` command so that the
latest commit hash of the code being run will be included in `loopd`.