loop: wait for chain notifier server to start #377
Conversation
| // try to re-attempt block epoch subscription. | ||
| select { | ||
| case <-time.After(50 * time.Millisecond): | ||
| continue |
There was a problem hiding this comment.
Perhaps add a log here that we're waiting for the chain notifier? Otherwise loop will just be hanging and user may not know why?
There was a problem hiding this comment.
Logging sounds good to me. And maybe increase the delay to 500ms to not spam lnd too much? It's got enough on its plate at this moment of startup anyway 😂
There was a problem hiding this comment.
Yeah the 50ms was a bit overkill :) Log added.
| return err | ||
| } | ||
|
|
||
| break |
There was a problem hiding this comment.
Do we need to break? Couldn't we just return err here? Either it's nil or it's a non-"process of starting" error.
There was a problem hiding this comment.
The function continues below. So getting here means we've succeeded with the connection.
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Just one nit, otherwise LGTM 💯
| return err | ||
| } | ||
|
|
||
| break |
There was a problem hiding this comment.
The function continues below. So getting here means we've succeeded with the connection.
| // try to re-attempt block epoch subscription. | ||
| select { | ||
| case <-time.After(50 * time.Millisecond): | ||
| continue |
There was a problem hiding this comment.
Logging sounds good to me. And maybe increase the delay to 500ms to not spam lnd too much? It's got enough on its plate at this moment of startup anyway 😂
bhandras
force-pushed
the
chainnoitifer_fix
branch
from
89638eb to
a0b67da
Compare
| if strings.Contains(err.Error(), | ||
| "in the process of starting") { | ||
|
|
||
| log.Warnf("LND chain notifier server not " + |
There was a problem hiding this comment.
nit: could just be Warn, but don't push again for this!
4 participants
No description provided.