multi: surface grpc error codes from server to client #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting our error was stifling any grpc error returned by the server. Instead, we bubble up our grpc error, setting an unknown code if the server did not specifically return an error code.
guggero
approved these changes
Jul 19, 2021
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
tACK, LGTM 💯
Before:
[loop] rpc error: code = Unknown desc = cannot initiate swap: rpc error: code = FailedPrecondition desc = target unreachable
After:
[loop] rpc error: code = FailedPrecondition desc = cannot initiate swap: target unreachable
bhandras
approved these changes
Jul 19, 2021
| // wrapGrpcError wraps the non-nil error provided with a message providing | ||
| // additional context, preserving the grpc code returned with the original | ||
| // error. If the original error has no grpc code, then codes.Unknown is used. | ||
| func wrapGrpcError(message string, err error) error { |
Member
There was a problem hiding this comment.
Is there an advantage of wrapping unknown errors in the few places in the PR vs just returning status.Error there with proper error codes?
Contributor
Author
There was a problem hiding this comment.
I think it's nice to be able to wrap with a bit more information and preserve the error? In the case of unknown errors, I think it's ok to add the unknown error code anyway, doesn't really take away much. We could go through the whole api and add error codes everywhere, but I think surfacing the error codes returned by the server is a good start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting our error was stifling any grpc error returned by the
server. Instead, we bubble up our grpc error, setting an unknown
code if the server did not specifically return an error code.
Fixes: #355
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes