loopout: do not report prepays and fix plugin type if acquire fails #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
reviewed
Feb 18, 2022
loopout.go
Outdated
| paymentSuccess, int32(attempts), dt.Milliseconds(), | ||
| ); err != nil { | ||
| s.log.Warnf("Failed to report routing result: %v", err) | ||
| // RoutingPluginNone is requested for prepays which we don't want to |
Contributor
There was a problem hiding this comment.
It's possible that we also have RoutingPluginNone for swap payments if we've got multiple payments going off at the same time, right?
loopout.go
Outdated
| s.log.Warnf("Failed to report routing result: %v", err) | ||
| // RoutingPluginNone is requested for prepays which we don't want to | ||
| // report. | ||
| if pluginType != RoutingPluginNone { |
Contributor
There was a problem hiding this comment.
Is there any point in reporting swap payments that use RoutingPluginNone so that we can compare them to ones that use the plugin? I'd guess not because they're also affected by the mission control changes?
If yes, I think we should pass in a reportPlugin bool ?
Member
Author
There was a problem hiding this comment.
The passed in bool is solves this nicely.
bhandras
force-pushed
the
routing-plugin-report-filter
branch
from
6ae379a to
a0a03d1
Compare
bhandras
force-pushed
the
routing-plugin-report-filter
branch
from
a0a03d1 to
32d55dc
Compare
yyforyongyu
approved these changes
Feb 18, 2022
carlaKC
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changes two things: