swap: HTLCV3 added #482
Merged
swap: HTLCV3 added #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
approved these changes
Apr 20, 2022
Member
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
Thanks for reopening!
LGTM 🚀
| ) | ||
| copy(senderKey[:], senderPubKey.SerializeCompressed()) | ||
| copy(receiverKey[:], receiverPubKey.SerializeCompressed()) | ||
| copy(senderKey[:], senderPubKey.SerializeCompressed()) |
Member
There was a problem hiding this comment.
nit: you can reverse the order of these two lines to make the diff smaller
bhandras
reviewed
Apr 20, 2022
Member
|
Found some missing bits:
Code is mostly ready though: 63c8242 |
arshbot
force-pushed
the
HtlcV3-taproot-base
branch
from
e6ff412 to
a038141
Compare
Contributor
Author
|
Addressed those gaps, and added some more documentation @bhandras |
guggero
suggested changes
Apr 21, 2022
bhandras
reviewed
Apr 21, 2022
arshbot
force-pushed
the
HtlcV3-taproot-base
branch
3 times, most recently
from
5b048e3 to
a1cff82
Compare
bhandras
requested changes
Apr 21, 2022
arshbot
force-pushed
the
HtlcV3-taproot-base
branch
2 times, most recently
from
3458925 to
af2d539
Compare
bhandras
reviewed
Apr 21, 2022
| copy(receiverKey[:], receiverPubKey.SerializeCompressed()) | ||
| copy(senderKey[:], senderPubKey.SerializeCompressed()) | ||
|
|
||
| randomSharedKey, err := hex.DecodeString( |
Member
There was a problem hiding this comment.
Not required now, but It'd be cool to have a unit test for keyspend as well.
arshbot
force-pushed
the
HtlcV3-taproot-base
branch
2 times, most recently
from
5c6d3ed to
a3d2710
Compare
In this commit we add the version 3 htlc, which is implemented with taproot script spending the two payment paths: the claim path case, and the timeout case.
arshbot
force-pushed
the
HtlcV3-taproot-base
branch
from
a3d2710 to
dec6dd7
Compare
guggero
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is duplicate of #473 which was erroneously merged and reverted by #481.