liquidity: persist manager's params to disk #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
force-pushed
the
db-params
branch
3 times, most recently
from
7cd7652 to
585db71
Compare
yyforyongyu
force-pushed
the
db-params
branch
2 times, most recently
from
075d5b3 to
e566280
Compare
|
@arshbot: review reminder |
arshbot
reviewed
Jun 1, 2022
Contributor
arshbot
left a comment
arshbot
left a comment
There was a problem hiding this comment.
These changes look good to me! Can we add documentation to the relevant command (perhaps right in the help of setparam) to inform users of how to clear saved params?
This commit refactors the `liquidity` by moving `Parameters` related code into one file.
This commit refactors the method `manager.SetParameters` to take a `SetLiquidityParamsRequest`. As we'll see in the following commit, this will enable us saving the params to disk more easily.
This commit adds a new bucket to save liquidity parameters. We've skipped the serialization and deserialization implementations here and leave them to be handled by the liquidity package.
Member
Author
Updated the description, PTAL |
This commit saves the RPC request used to construct the `Parameters` on disk. Since it's a proto message, an easy way to read/write it is to rely on the proto marshal/unmarshal methods. A side effect is that migration also becomes easy as proto message have its own internal mechanism to keep track of the compatibility.
arshbot
approved these changes
Jun 7, 2022
Contributor
arshbot
left a comment
arshbot
left a comment
There was a problem hiding this comment.
LGTM! Great description too :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the params to a file can be quite cumbersome when it comes to migration, and also is prone to bugs. This PR replaces #490 by saving the data into db instead.
Note that we are saving the RPC request here, which has a nice feature as it handles compatibility very well, as long as the tag numbers are used correctly.
TODO: