looprpc/gen_protos.sh: remove js build tag #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sputn1ck
reviewed
Sep 8, 2022
Contributor
Author
|
@sputn1ck of course! pushed it up |
guggero
approved these changes
Sep 9, 2022
bhandras
approved these changes
Sep 9, 2022
|
@kaloudis, remember to re-request review from reviewers when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of Lightning Node Connect mobile efforts, we need to remove the restrictions imposed by the js build tag in order to use the proto JSON callbacks on mobile.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes