multi: sunset support for nested segwit HTLCs #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
sunset-htlcv1
branch
from
33b5c2a to
dce5cbe
Compare
Previously view may have set the output type wrongly for internal p2wsh and p2tr loop-in swaps which is corrected in this commit.
This commit removes all code related to NP2WSH htlcs. These were historically used when segwit adoption was very sporadic and are not used anywhere anymore. Some historical swaps stored in the DB may be listed with incorrect htlc adresses from here on.
bhandras
force-pushed
the
sunset-htlcv1
branch
from
dce5cbe to
fccd5d9
Compare
bhandras
force-pushed
the
sunset-htlcv1
branch
from
fccd5d9 to
7341a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for NP2WSH HTLCs from the code base. This is a breaking change for those clients who need to list those old swaps as the displayed HTLC address will be incorrect.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes