Autoloop-in flake fix #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the FeePPM miner fee fix there has probably been a race condition in this test. The test would expect only one of the two quotes to work, as one had a marginally high miner fee. After the FeePPM fix that miner fee was considered valid and we dispatched two swaps instead of one, with the test setup examining the first one that reached the go channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the FeePPM miner fee fix there has probably been a race condition in this test. The test would expect only one of the two quotes to work, as one had a marginally high miner fee. After the FeePPM fix that miner fee was considered valid and we dispatched two swaps instead of one, with the test setup examining the first one that reached the go channel.