reservation: fix exiting on fetchL402 #699
Merged
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
force-pushed
the
reservation_fix_erroring_out
branch
from
ad63660 to
44f9ccd
Compare
hieblmi
approved these changes
Feb 9, 2024
| // fetchL402 fetches the L402 from the server. This method will keep on | ||
| // retrying until it gets a valid response. | ||
| func (m *Manager) fetchL402(ctx context.Context) { | ||
| timer := time.NewTimer(0) |
Collaborator
There was a problem hiding this comment.
for consistency you could use the same timer pattern as below: case <-time.After(time.Second * 10):
Member
Author
There was a problem hiding this comment.
They work differently though. The timer here has the benefit of starting as a 0 timer, thus reducing the initial time until the l402 is first fetched. If we do case <-time.After(time.Second * 10): we'll wait 10 seconds first.
Member
Author
There was a problem hiding this comment.
For the reconnecting case it makes sense to always wait 10 seconds
sputn1ck
force-pushed
the
reservation_fix_erroring_out
branch
from
44f9ccd to
28ddece
Compare
This commit changes the way the reservation manager works, by not exiting when the fetchL402 call fails. This ensures that a client can still run loop, even if they don't have outbound capacity or the loop server is offline.
sputn1ck
force-pushed
the
reservation_fix_erroring_out
branch
from
28ddece to
7578349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the reservation manager works, by not exiting when the
fetchL402call fails. This ensures that a client can still run loop, even if they don't have outbound capacity or the loop server is offline.