sqldb: fix migration config consistency coverage

[ziggie1984]

Summary

• register the migration 14 config entry so the main migration list matches the embedded SQL files
• add the reverse migration file coverage check and harden the consistency test invariants
• reject schema version regressions and require migration names to match embedded SQL filenames

Testing

• GOCACHE=/tmp/go-build-cache go test -run 'TestMigrationConfigConsistency$' -count=1
• GOCACHE=/tmp/go-build-cache go test -tags='test_native_sql' -run 'TestMigration(ConfigConsistency|FilesAllRegistered)$' -count=1

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and consistency of the SQL database migration system. It ensures that the in-code migration configuration accurately reflects the embedded SQL migration files, prevents accidental schema version regressions, and enforces strict naming conventions, thereby improving the reliability of database schema evolution.

Highlights

• Migration Configuration Alignment: Registered the '000014_payments_no_fail_reason_index' migration config entry to ensure the main migration list matches the embedded SQL files.
• Enhanced Migration Consistency Checks: Introduced a new test ('TestMigrationFilesAllRegistered') to cover reverse migration file consistency and hardened existing consistency test invariants.
• Schema Version and Naming Enforcement: Implemented checks to reject schema version regressions and enforce that migration names precisely match their corresponding embedded SQL filenames.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new test, TestMigrationFilesAllRegistered, to ensure that all SQL migration files have corresponding entries in the Go migration configuration. It also enhances TestMigrationConfigConsistency by correcting the previous schema version calculation, enforcing monotonically increasing schema versions, and verifying that migration names in the configuration match their respective SQL file names. Furthermore, an existing migration entry is renamed, and a new migration for payments is added. There is no feedback to provide on the review comments as none were provided.

[github-actions]

PR Severity: CRITICAL

Automated classification | 1 file (non-test) | 7 lines changed

CRITICAL (1 file)

• sqldb/migrations.go - Database migration file in sqldb/; per classification rules, all sqldb/ migration files are unconditionally CRITICAL

Low (2 files - excluded from scoring)

• sqldb/migrations_dev_test.go - Test file (excluded)
• sqldb/migrations_test.go - Test file (excluded)

Analysis

This PR touches sqldb/migrations.go, which falls under the sqldb/* database migration category. Per the classification rules, database migrations (channeldb/migration*, sqldb/, wtdb/) are always CRITICAL regardless of the size or complexity of the change.

The change is small (6 additions, 1 deletion in the non-test file) and is accompanied by new migration tests, which is good practice. However, database migrations carry inherent risk - a faulty migration can corrupt channel state or render a node unable to start. This warrants expert review to ensure:

• Migration logic is correct and idempotent
• Any schema changes are backward-compatible or properly versioned
• The migration is covered by the new tests added in this PR

---

To override, add a severity-override-{critical,high,medium,low} label.
<!-- pr-severity-bot -->

[yyforyongyu]

LGTM 🧰

[Roasbeef]

LGTM 🐔