Skip to content

mod: bump neutrino dependency#10800

Merged
yyforyongyu merged 2 commits into
lightningnetwork:masterfrom
ziggie1984:bump-neutrino-0f87fa7
May 13, 2026
Merged

mod: bump neutrino dependency#10800
yyforyongyu merged 2 commits into
lightningnetwork:masterfrom
ziggie1984:bump-neutrino-0f87fa7

Conversation

@ziggie1984
Copy link
Copy Markdown
Collaborator

Updates github.com/lightninglabs/neutrino from v0.16.2 to v0.16.3-0.20260508212153-0f87fa7c4b36, the latest upstream master commit.

Verification:

  • go test ./chainntnfs/neutrinonotify ./blockcache ./discovery
  • go test -p 1 ./lnwallet/btcwallet ./routing/chainview

Note: the first full targeted run hit a stale local rpctest port lock; after removing the stale lock, the affected packages passed.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine dependency update for the neutrino library to track the latest upstream master commit. The change ensures the project benefits from the most recent improvements and fixes provided by the neutrino maintainers, with verified test coverage to ensure no regressions were introduced.

Highlights

  • Dependency Update: Updated the github.com/lightninglabs/neutrino dependency from v0.16.2 to v0.16.3-0.20260508212153-0f87fa7c4b36.
  • Verification: Confirmed stability through targeted test runs across chainntnfs, blockcache, discovery, lnwallet, and routing packages.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ziggie1984 ziggie1984 force-pushed the bump-neutrino-0f87fa7 branch from bb7083d to 1e11d17 Compare May 12, 2026 01:55
@ziggie1984 ziggie1984 self-assigned this May 12, 2026
@ziggie1984 ziggie1984 added this to v0.21 May 12, 2026
@ziggie1984 ziggie1984 added this to the v0.21.0 milestone May 12, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/lightninglabs/neutrino dependency from version v0.16.2 to a specific commit-based version v0.16.3-0.20260508212153-0f87fa7c4b36. I have no feedback to provide.

@saubyk saubyk moved this to In progress in v0.21 May 12, 2026
Copy link
Copy Markdown
Collaborator

@saubyk saubyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@ziggie1984 ziggie1984 force-pushed the bump-neutrino-0f87fa7 branch from 1e11d17 to 248ecc1 Compare May 12, 2026 16:44
@github-actions github-actions Bot added the severity-medium Focused review required label May 12, 2026
@github-actions
Copy link
Copy Markdown

PR Severity: MEDIUM. Automated classification: 3 files (2 non-generated), 5 lines changed. Files: go.mod (dependency update, medium), sample-lnd.conf (config sample, medium), go.sum (auto-generated, excluded). No critical or high packages touched. No severity bump conditions triggered. To override, add a severity-override label. <!-- pr-severity-bot -->

The neutrino bump updates the default UserAgentVersion from
"0.12.0-beta" to "0.16.2", which made the sample-conf check fail.
@ziggie1984 ziggie1984 force-pushed the bump-neutrino-0f87fa7 branch from c5cc887 to 037549d Compare May 12, 2026 18:15
@ziggie1984 ziggie1984 requested a review from yyforyongyu May 12, 2026 21:22
Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛵

@yyforyongyu yyforyongyu merged commit 066669a into lightningnetwork:master May 13, 2026
44 of 45 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in v0.21 May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog severity-medium Focused review required

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants