Skip to content

mod: drop queue + kvdb replaces, require tagged versions#10857

Merged
yyforyongyu merged 1 commit into
lightningnetwork:masterfrom
Roasbeef:drop-queue-kvdb-replaces
May 28, 2026
Merged

mod: drop queue + kvdb replaces, require tagged versions#10857
yyforyongyu merged 1 commit into
lightningnetwork:masterfrom
Roasbeef:drop-queue-kvdb-replaces

Conversation

@Roasbeef
Copy link
Copy Markdown
Member

In this PR, we knock out most of the replace directive cleanup tracked in
#10854. Now that we've cut queue/v1.2.0 and kvdb/v1.5.0, we can drop the
two in-tree replace directives that pointed the root module at ./queue and
./kvdb, and require the tagged releases instead.

queue/v1.2.0 is the BackpressureQueue[T] work (the "new queue package" the
TODO was waiting on), and kvdb/v1.5.0 completes the pgx/v4 -> pgx/v5
migration. Both tags point at the same commit where each module last changed
on master, so what we build doesn't change: we're just consuming the modules
as proper tagged deps now instead of via the local replace.

We're leaving the sqldb replace in place. That one's still gated on the
gossip V2 sqldb changes landing before we can cut its tag, so it stays as-is
for now (still tracked in #10854).

Backport

The queue half of this is being backported to v0.21 via #10847 (the rc3
bump). kvdb is master-only: 0.21 stays on kvdb v1.4.16/pgx-v4, so the
pgx/v5 migration doesn't ride into the release.

Remaining from #10854

  • Cut kvdb/v1.5.0 (pgx/v5)
  • Cut queue/v1.2.0 (BackpressureQueue[T])
  • Drop the queue + kvdb replace directives, bump requires
  • Cut the next sqldb tag once the gossip V2 work lands, then drop the last replace

In this commit, we drop the in-tree replace directives for the queue and
kvdb submodules now that both have proper tags. queue/v1.2.0 carries the
BackpressureQueue[T] work, and kvdb/v1.5.0 completes the pgx/v4 -> pgx/v5
migration. Both tags point at the same commit where each module last
changed, so swapping the local copies for the tagged versions doesn't
change what we build.

We keep the sqldb replace for now: that one's still waiting on the gossip
V2 sqldb changes before we can cut its tag.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the project's dependency management by transitioning from local module replacements to official tagged releases for the 'queue' and 'kvdb' packages. This shift reflects the stabilization of these components, specifically incorporating the 'BackpressureQueue[T]' implementation and the migration to 'pgx/v5'. The 'sqldb' replace directive remains in place pending further development.

Highlights

  • Dependency Management: Removed local replace directives for 'queue' and 'kvdb' modules in favor of their newly tagged versions, v1.2.0 and v1.5.0 respectively.
  • Module Updates: Updated 'go.mod' and 'go.sum' to require the official tagged releases of 'queue' and 'kvdb', ensuring consistent builds.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependencies for github.com/lightningnetwork/lnd/kvdb to v1.5.0 and github.com/lightningnetwork/lnd/queue to v1.2.0 in go.mod and go.sum. It also removes the local replace directives for both of these packages. I have no feedback to provide as there are no review comments or issues identified in these dependency updates.

@github-actions github-actions Bot added the severity-medium Focused review required label May 28, 2026
@github-actions
Copy link
Copy Markdown

🟡 PR Severity: MEDIUM

Automated classification | 2 files | 14 lines changed

🟡 Medium (2 files)
  • go.mod - Go module dependency manifest; root-level infrastructure file not in any critical/high package path
  • go.sum - Go module checksum file; auto-maintained alongside go.mod

Analysis

This PR only modifies go.mod and go.sum, indicating a dependency update (2 additions to go.sum, 8 deletions and 2 additions in go.mod, likely replacing or upgrading a dependency). Neither file falls under any critical or high-severity package path. With only 2 files and 14 lines changed, no severity bump rules apply.

The change warrants a focused review to ensure the dependency bump is intentional, the updated module versions are trustworthy, and no transitive dependency issues are introduced — but does not require expert-level Lightning protocol knowledge.


To override, add a severity-override-{critical,high,medium,low} label.
<!-- pr-severity-bot -->

Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🦋

@yyforyongyu yyforyongyu merged commit ca047de into lightningnetwork:master May 28, 2026
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity-medium Focused review required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants