mod: drop queue + kvdb replaces, require tagged versions#10857
Conversation
In this commit, we drop the in-tree replace directives for the queue and kvdb submodules now that both have proper tags. queue/v1.2.0 carries the BackpressureQueue[T] work, and kvdb/v1.5.0 completes the pgx/v4 -> pgx/v5 migration. Both tags point at the same commit where each module last changed, so swapping the local copies for the tagged versions doesn't change what we build. We keep the sqldb replace for now: that one's still waiting on the gossip V2 sqldb changes before we can cut its tag.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up the project's dependency management by transitioning from local module replacements to official tagged releases for the 'queue' and 'kvdb' packages. This shift reflects the stabilization of these components, specifically incorporating the 'BackpressureQueue[T]' implementation and the migration to 'pgx/v5'. The 'sqldb' replace directive remains in place pending further development. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the dependencies for github.com/lightningnetwork/lnd/kvdb to v1.5.0 and github.com/lightningnetwork/lnd/queue to v1.2.0 in go.mod and go.sum. It also removes the local replace directives for both of these packages. I have no feedback to provide as there are no review comments or issues identified in these dependency updates.
🟡 PR Severity: MEDIUM
🟡 Medium (2 files)
AnalysisThis PR only modifies The change warrants a focused review to ensure the dependency bump is intentional, the updated module versions are trustworthy, and no transitive dependency issues are introduced — but does not require expert-level Lightning protocol knowledge. To override, add a |
In this PR, we knock out most of the replace directive cleanup tracked in
#10854. Now that we've cut
queue/v1.2.0andkvdb/v1.5.0, we can drop thetwo in-tree replace directives that pointed the root module at
./queueand./kvdb, and require the tagged releases instead.queue/v1.2.0is theBackpressureQueue[T]work (the "new queue package" theTODO was waiting on), and
kvdb/v1.5.0completes the pgx/v4 -> pgx/v5migration. Both tags point at the same commit where each module last changed
on master, so what we build doesn't change: we're just consuming the modules
as proper tagged deps now instead of via the local replace.
We're leaving the
sqldbreplace in place. That one's still gated on thegossip V2 sqldb changes landing before we can cut its tag, so it stays as-is
for now (still tracked in #10854).
Backport
The queue half of this is being backported to v0.21 via #10847 (the rc3
bump). kvdb is master-only: 0.21 stays on
kvdb v1.4.16/pgx-v4, so thepgx/v5 migration doesn't ride into the release.
Remaining from #10854
kvdb/v1.5.0(pgx/v5)queue/v1.2.0(BackpressureQueue[T])sqldbtag once the gossip V2 work lands, then drop the last replace