Skip to content

build: update btcwallet dependency to include initial sync improvements#3141

Merged
cfromknecht merged 1 commit intolightningnetwork:masterfrom
wpaulino:instant-wallet-startup
Jun 14, 2019
Merged

build: update btcwallet dependency to include initial sync improvements#3141
cfromknecht merged 1 commit intolightningnetwork:masterfrom
wpaulino:instant-wallet-startup

Conversation

@wpaulino
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino commented May 30, 2019

Depends on btcsuite/btcwallet#618.

Since we'll no longer fetch blocks headers for the whole chain, but only for the latest 10,000 blocks,
this somewhat addresses #1528 and #1545.

Fixes #1854.
Fixes #3166.

@hsjoberg
Copy link
Copy Markdown
Contributor

hsjoberg commented Jun 8, 2019

Regarding #3166, can confirm that this seems to fix closing-down problems I've been having running lnd+neutrino on Android.

@Roasbeef
Copy link
Copy Markdown
Member

Needs a rebase now that the dependent PR is in!

Copy link
Copy Markdown
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@cfromknecht
Copy link
Copy Markdown
Contributor

Don't thinkk this related?

=== RUN   TestInterfaces/neutrino_catch_up_client_on_historical_block_epoch_ntfns
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@wpaulino
Copy link
Copy Markdown
Contributor Author

Don’t think so either, have seen it before in builds for other PRs.

@cfromknecht
Copy link
Copy Markdown
Contributor

Same here, tho it does seem recent

Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIGINT does not shut down lnd when backend node is unreachable Handle starting LND with unsynced chain backend.

5 participants