htlcswitch/hop: new package for hop payload parsing/encapsulation#3466
Merged
Conversation
cfromknecht
force-pushed
the
htlcswitch-hop
branch
from
5df1319 to
ea46f7c
Compare
cfromknecht
added
code health
cfromknecht
force-pushed
the
htlcswitch-hop
branch
from
ea46f7c to
033fdd8
Compare
joostjager
reviewed
Sep 4, 2019
cfromknecht
force-pushed
the
htlcswitch-hop
branch
from
033fdd8 to
61e0c6f
Compare
joostjager
approved these changes
Sep 5, 2019
cfromknecht
force-pushed
the
htlcswitch-hop
branch
from
61e0c6f to
138b079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #3441
This PR begins the process of moving our hop payload processing within lnd into its own subpackage,
htlcswitch/hop. This will allow the processing to be imported into thehtlcswitchandcontractcourt, and also have a singlehop.Payloadobject that can be shared with the invoice registry. The last four commits are predominately a code move, but it will be nice to make progress on the more trivial things so we can do less rebasing on #3442This will also allow @joostjager to add his follow up in moving the
HopIteratorcomponents into this package, and establish a stable base to continue mpp/amp development