routing: send to route max hops check#3818
Merged
joostjager merged 3 commits intolightningnetwork:masterfrom Dec 19, 2019
Merged
routing: send to route max hops check#3818joostjager merged 3 commits intolightningnetwork:masterfrom
joostjager merged 3 commits intolightningnetwork:masterfrom
Conversation
joostjager
force-pushed
the
check-max-onion
branch
3 times, most recently
from
8e05efe to
eb48816
Compare
joostjager
force-pushed
the
check-max-onion
branch
3 times, most recently
from
90fb7a3 to
2ae1156
Compare
joostjager
changed the title
joostjager
force-pushed
the
check-max-onion
branch
from
2ae1156 to
124173c
Compare
joostjager
requested review from
guggero and
halseth
and removed request for
guggero and
halseth
Member
|
Let's also update this to pin to the latest version of |
joostjager
force-pushed
the
check-max-onion
branch
from
124173c to
5593561
Compare
Contributor
Author
|
Updated to f34e9dc1651d174d79cc7a9965ac26844eb4ec98 |
guggero
approved these changes
Dec 16, 2019
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice bugfix, looks good to me!
I only have two non-blocking comments/nits.
joostjager
force-pushed
the
check-max-onion
branch
from
5593561 to
d85f378
Compare
wpaulino
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on lightningnetwork/lightning-onion#45
A follow up pr #3841 will also limit path finding to the maximum payload size of 1300 bytes.
Fixes #3712