channeldb: fuzz (de)serialization of contract data#8045
Open
morehouse wants to merge 8 commits intolightningnetwork:masterfrom
Open
channeldb: fuzz (de)serialization of contract data#8045morehouse wants to merge 8 commits intolightningnetwork:masterfrom
morehouse wants to merge 8 commits intolightningnetwork:masterfrom
Conversation
Allows easy fuzzing of the channel info serialization and deserialization.
Tests the encoding and decoding of OpenChannel data that is done by putChanInfo and fetchChanInfo.
Allows easy fuzzing of the revocation state serialization and deserialization.
Tests the encoding and decoding of OpenChannel data that is done by putChanRevocationState and fetchChanRevocationState.
morehouse
added
database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fuzz targets for serialization and deserialization of all DB data used by
contractcourt. It is especially important that this data is correctly serialized and deserialized since any errors can lead to loss of funds when settling on chain.Extra effort was made to fuzz the serialization of the data first, and then deserialize the serialized data. This is more work than doing the usual deserialize-serialize-deserialize sequence we do for other fuzz tests, but it makes more sense for
channeldbwhere all data stored in the DB must have been serialized by LND first.