Add Tutorial for LOJ-1266: Points in Rectangle (en)#444
Merged
rebornplusplus merged 18 commits intolightoj-dev:mainfrom May 30, 2023
Merged
Add Tutorial for LOJ-1266: Points in Rectangle (en)#444rebornplusplus merged 18 commits intolightoj-dev:mainfrom
rebornplusplus merged 18 commits intolightoj-dev:mainfrom
Conversation
super easy explanation
Rabby033
changed the title
rebornplusplus
requested changes
May 13, 2023
Member
rebornplusplus
left a comment
rebornplusplus
left a comment
There was a problem hiding this comment.
Hiya, here's a first pass. The overall write-up looks good. I only have a few suggestions here and there.
rebornplusplus
changed the title
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Image Added in same directory
Contributor
Author
|
@rebornplusplus please checkout my response according to your feedback |
rebornplusplus
requested changes
May 27, 2023
Member
There was a problem hiding this comment.
There is an unnecessary file solve.txt in the 1266/ directory. Please remove that.
I have added a few more suggestions to improve the PR. There are some recurring issues:
- Please don't use
<br>. - Please use a single space after a punctuation like
,,.,:etc. And before, usually don't add any spaces.
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Co-authored-by: Rafid Bin Mostofa <rebornplusplus@gmail.com>
Contributor
Author
|
@rebornplusplus I am requesting you to check it again . Changes done based on your feedback . |
rebornplusplus
approved these changes
May 30, 2023
Member
rebornplusplus
left a comment
rebornplusplus
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
super easy explanation