-
Notifications
You must be signed in to change notification settings - Fork 285
add Navigation WebAPI
#1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add Navigation WebAPI
#1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
620a5d3 to
fee8f5c
Compare
|
Duckduckgo integration test is failing on this branch, even after a rebase against |
karlseguin
reviewed
Oct 21, 2025
Should be fixed with 9c4367b. The URL |
karlseguin
reviewed
Oct 22, 2025
karlseguin
reviewed
Oct 22, 2025
krichprollsch
approved these changes
Oct 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still pretty rough around the edges for now (and is incomplete)
This implements the
NavigationWebAPI.Historyis now a compatibility layer overNavigation, allowing them to share the same underlying entries.testinghas been changed, usingfetchWaitand loading a secondary testing html file that checks for the appropriate conditions when we need to load a secondary page (such as withHistoryorNavigation. thenavigateFromWebAPIhas also been changed, adding a field, that allows it so serve as the central way to navigate with proper hooks intoNavigation.There are a few Events that need to be completed so far, such as
NavigateEvent, and a lot of conditions that need extra testing (such as reloading).Looking to get this merged soon, just to prevent this from drifting off too far. There is still a good chunk of work left to be fully WPT compliant (such as firing events at the proper time), but a lot of these WPTs depend on other browser features (like
pageshow) that have to be implemented separately. I'm going to continue working on Navigation, specifically on getting most of the tests to pass.