Skip to content

cdp: DOM.getouterHTML #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krichprollsch merged 2 commits into from
Nov 17, 2025
Merged

cdp: DOM.getouterHTML #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
263dab0
cdp: add DOM.getOuterHTML
krichprollsch Nov 13, 2025
c2827a0
cdp: add browser.Close but ignore it
krichprollsch Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cdp/domains/browser.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ pub fn processMessage(cmd: anytype) !void {
grantPermissions,
getWindowForTarget,
setDownloadBehavior,
close,
}, cmd.input.action) orelse return error.UnknownMethod;

switch (action) {
Expand All @@ -54,6 +55,7 @@ pub fn processMessage(cmd: anytype) !void {
.grantPermissions => return grantPermissions(cmd),
.getWindowForTarget => return getWindowForTarget(cmd),
.setDownloadBehavior => return setDownloadBehavior(cmd),
.close => return cmd.sendResult(null, .{}),
}
}

Expand Down
24 changes: 24 additions & 0 deletions src/cdp/domains/dom.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const css = @import("../../browser/dom/css.zig");
const parser = @import("../../browser/netsurf.zig");
const dom_node = @import("../../browser/dom/node.zig");
const Element = @import("../../browser/dom/element.zig").Element;
const dump = @import("../../browser/dump.zig");

pub fn processMessage(cmd: anytype) !void {
const action = std.meta.stringToEnum(enum {
Expand All @@ -41,6 +42,7 @@ pub fn processMessage(cmd: anytype) !void {
getBoxModel,
requestChildNodes,
getFrameOwner,
getOuterHTML,
}, cmd.input.action) orelse return error.UnknownMethod;

switch (action) {
Expand All @@ -58,6 +60,7 @@ pub fn processMessage(cmd: anytype) !void {
.getBoxModel => return getBoxModel(cmd),
.requestChildNodes => return requestChildNodes(cmd),
.getFrameOwner => return getFrameOwner(cmd),
.getOuterHTML => return getOuterHTML(cmd),
}
}

Expand Down Expand Up @@ -494,6 +497,27 @@ fn getFrameOwner(cmd: anytype) !void {
return cmd.sendResult(.{ .nodeId = node.id, .backendNodeId = node.id }, .{});
}

fn getOuterHTML(cmd: anytype) !void {
const params = (try cmd.params(struct {
nodeId: ?Node.Id = null,
backendNodeId: ?Node.Id = null,
objectId: ?[]const u8 = null,
includeShadowDOM: bool = false,
})) orelse return error.InvalidParams;

if (params.includeShadowDOM) {
log.warn(.cdp, "not implemented", .{ .feature = "DOM.getOuterHTML: Not implemented includeShadowDOM parameter" });
}
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;

const node = try getNode(cmd.arena, bc, params.nodeId, params.backendNodeId, params.objectId);

var aw = std.Io.Writer.Allocating.init(cmd.arena);
try dump.writeNode(node._node, .{}, &aw.writer);

return cmd.sendResult(.{ .outerHTML = aw.written() }, .{});
}

const testing = @import("../testing.zig");

test "cdp.dom: getSearchResults unknown search id" {
Expand Down