First implementation of Event system #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
francisbouvier
force-pushed
the
events
branch
2 times, most recently
from
51f921d to
1c9a8c2
Compare
src/dom/event_target.zig
Outdated
| eventType: []const u8, | ||
| cbk: Callback, | ||
| ) !void { | ||
| // TODO: when can we free this allocation? |
Member
There was a problem hiding this comment.
on the removeListener call maybe?
Member
Author
There was a problem hiding this comment.
Yes of course. But I want to investigate the lifetime of the Callback to see if we can do it before.
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
francisbouvier
force-pushed
the
events
branch
3 times, most recently
from
e827f7f to
5952902
Compare
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
francisbouvier
force-pushed
the
events
branch
3 times, most recently
from
dcd7b74 to
ef6c36b
Compare
krichprollsch
approved these changes
Jan 19, 2024
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Member
|
In order to try to pass some of the new WPT tests, I suggest to implement
|
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
src/netsurf.zig
Outdated
| // EventListener | ||
| pub const EventListener = c.dom_event_listener; | ||
|
|
||
| pub fn eventListenerGetData(lst: *EventListener) ?*anyopaque { |
Member
There was a problem hiding this comment.
You could directly return a *Callback here isn't it?
src/netsurf.zig
Outdated
| return getVtable(c.dom_event_target_vtable, EventTarget, et); | ||
| } | ||
|
|
||
| pub fn eventTargetHasListener(et: *EventTarget, typ: []const u8, cbk_id: usize) !?*EventListener { |
Member
There was a problem hiding this comment.
I'm not sure about the cbk_id: usize.
It seems inconsistent w/ the eventTargetAddEventListener signature which expects a cbk_ptr: *Callback.
And check if callback has been already added in addEventListener Signed-off-by: Francis Bouvier <francis@lightpanda.io>
francisbouvier
force-pushed
the
events
branch
from
b9b57bf to
9ba4c69
Compare
And unify the way allocator is used on eventTarget add/remove listener Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
krichprollsch
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36