Skip to content

Manually "clone" processing_instruction #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Manually "clone" processing_instruction #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/browser/dom/processing_instruction.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const std = @import("std");

const parser = @import("../netsurf.zig");
const Node = @import("node.zig").Node;
const SessionState = @import("../env.zig").SessionState;

// https://dom.spec.whatwg.org/#processinginstruction
pub const ProcessingInstruction = struct {
Expand All @@ -35,8 +36,15 @@ pub const ProcessingInstruction = struct {
return try parser.nodeName(parser.processingInstructionToNode(self));
}

pub fn _cloneNode(self: *parser.ProcessingInstruction, _: ?bool) !*parser.ProcessingInstruction {
return try parser.processInstructionCopy(self);
// There's something wrong when we try to clone a ProcessInstruction normally.
// The resulting object can't be cast back into a node (it crashes). This is
// a simple workaround.
pub fn _cloneNode(self: *parser.ProcessingInstruction, _: ?bool, state: *SessionState) !*parser.ProcessingInstruction {
return try parser.documentCreateProcessingInstruction(
@ptrCast(state.document),
try get_target(self),
(try get_data(self)) orelse "",
);
}

pub fn get_data(self: *parser.ProcessingInstruction) !?[]const u8 {
Expand All @@ -61,5 +69,6 @@ test "Browser.DOM.ProcessingInstruction" {
.{ "pi.data", "foo" },

.{ "let pi2 = pi.cloneNode()", "undefined" },
.{ "pi2.nodeType", "7" },
}, .{});
}
Loading